-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong example misguide user to catch panic #414
wrong example misguide user to catch panic #414
Conversation
Signed-off-by: wander1024 <yawhua1024@gmail.com>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
=======================================
Coverage 74.28% 74.28%
=======================================
Files 42 42
Lines 1357 1357
=======================================
Hits 1008 1008
Misses 295 295
Partials 54 54 Continue to review full report at Codecov.
|
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution :). Sorry for the confusion here. |
With
How is it supposed to log a panic occurred? |
Signed-off-by: wander1024 yawhua1024@gmail.com
recovery should be placed the first.
#410
#215